Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prefix $ and > from manual #2404

Merged
merged 1 commit into from
May 24, 2019
Merged

Remove prefix $ and > from manual #2404

merged 1 commit into from
May 24, 2019

Conversation

styfle
Copy link
Contributor

@styfle styfle commented May 23, 2019

These are not literal characters so when you copy/paste, it fails.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit ccdab61 into denoland:master May 24, 2019
@styfle styfle deleted the patch-3 branch May 24, 2019 00:40
@hayd
Copy link
Contributor

hayd commented May 24, 2019

There's a bunch of others on the page, is there a reason they weren't also removed?

Edit: I like the $ in the examples actually.

@styfle
Copy link
Contributor Author

styfle commented May 24, 2019

@hayd I guess I didn't read that far yet. I was just trying to install.

It looks like some of them include responses too so maybe thats why that prefix with $.

Ideally there would be css to include this prefix so copy/paste wouldn't pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants