Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: avoid building module graph if dynamic specifier already in graph #24035

Merged

Conversation

dsherret
Copy link
Member

Real fix instead of #24020

Benchmark 1: ../../deno/deno_old run -A repro.ts
  Time (mean ± σ):     272.0 ms ±   5.4 ms    [User: 267.9 ms, System: 95.2 ms]
  Range (min … max):   267.1 ms … 287.0 ms    11 runs
 
Benchmark 2: ../../deno/target/release/deno run -A repro.ts
  Time (mean ± σ):     237.2 ms ±   2.0 ms    [User: 236.0 ms, System: 93.1 ms]
  Range (min … max):   235.6 ms … 243.0 ms    12 runs
 
Summary
  ../../deno/target/release/deno run -A repro.ts ran
    1.15 ± 0.02 times faster than ../../deno/deno_old run -A repro.ts
Benchmark 1: ../../deno/deno_old run -A repro2.ts
  Time (mean ± σ):     202.2 ms ±   3.4 ms    [User: 233.0 ms, System: 61.3 ms]
  Range (min … max):   199.1 ms … 211.7 ms    14 runs
 
Benchmark 2: ../../deno/target/release/deno run -A repro2.ts
  Time (mean ± σ):     175.8 ms ±   1.8 ms    [User: 207.7 ms, System: 59.7 ms]
  Range (min … max):   173.8 ms … 179.9 ms    16 runs
 
Summary
  ../../deno/target/release/deno run -A repro2.ts ran
    1.15 ± 0.02 times faster than ../../deno/deno_old run -A repro2.ts

@dsherret dsherret changed the title perf: avoid building module graph if roots already in graph perf: avoid building module graph if dynamic specifier already in graph May 29, 2024
@dsherret dsherret merged commit 814ac9a into denoland:main May 29, 2024
17 checks passed
@dsherret dsherret deleted the perf_avoid_building_module_graph_more2 branch May 29, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants