fix: bump cache sqlite dbs to v2 for WAL journal mode change #24030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
May 29, 2024
marvinhagemeister
approved these changes
May 29, 2024
dsherret
commented
May 29, 2024
| use super::cache_db::CacheFailure; | ||
| use deno_ast::ModuleSpecifier; | ||
| use deno_core::error::AnyError; | ||
| use deno_runtime::deno_webstorage::rusqlite::params; | ||
|
|
||
| pub static TYPE_CHECK_CACHE_DB: CacheDBConfiguration = CacheDBConfiguration { | ||
| table_initializer: concat!( | ||
| "CREATE TABLE IF NOT EXISTS checkcache ( | ||
| check_hash TEXT PRIMARY KEY |
There was a problem hiding this comment.
These are now stored as integers.
| @@ -28,40 +28,19 @@ WHERE | |||
| LIMIT 1"; | |||
|
|
|||
| pub static MODULE_INFO_CACHE_DB: CacheDBConfiguration = CacheDBConfiguration { | |||
| table_initializer: "CREATE TABLE IF NOT EXISTS moduleinfocache ( | |||
| specifier TEXT PRIMARY KEY, | |||
| media_type TEXT NOT NULL, | |||
| @@ -3,16 +3,17 @@ | |||
| use std::hash::Hasher; | |||
|
|
|||
| /// A very fast insecure hasher that uses the xxHash algorithm. | |||
| #[derive(Default)] | |||
There was a problem hiding this comment.
Now forces someone to decide whether to include the deno version in the hash or not.
dsherret
commented
May 29, 2024
| .query_row(query, params![key.as_u64().to_string()], |row| { | ||
| let res = self.conn.query_row( | ||
| query, | ||
| params![CacheDBHash::new(key.as_u64())], |
There was a problem hiding this comment.
Opened denoland/deno_graph#491 to make the hash have the deno_graph version in it.
Edit: Included that here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #23955 we changed the sqlite db journal mode to WAL. This causes issues when someone is running an old version of Deno using TRUNCATE and a new version because the two fight against each other.