Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deno_task): more descriptive error message #24001

Merged
merged 3 commits into from
May 28, 2024

Conversation

WingZer0o
Copy link
Contributor

#23990 Added a more descriptive error message for a missing deno.json config file.

@CLAassistant
Copy link

CLAassistant commented May 28, 2024

CLA assistant check
All committers have signed the CLA.

cli/args/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I left one comment to address.

Co-authored-by: Satya Rohith <[email protected]>
Signed-off-by: Mike Mulchrone <[email protected]>
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@WingZer0o
Copy link
Contributor Author

WingZer0o commented May 28, 2024 via email

@satyarohith satyarohith changed the title error(cli/args): more descriptive error message fix(deno_task): more descriptive error message May 28, 2024
@satyarohith satyarohith enabled auto-merge (squash) May 28, 2024 13:08
@satyarohith satyarohith disabled auto-merge May 28, 2024 13:09
@satyarohith satyarohith enabled auto-merge (squash) May 28, 2024 13:10
@satyarohith satyarohith merged commit dc5c799 into denoland:main May 28, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants