perf(cli): Optimize setting up node_modules on macOS

[nathanwhit]

Hard linking (linkat) is ridiculously slow on mac. copyfile is better, but what's even faster is clonefile. It doesn't have the space savings that comes with hardlinking, but the performance difference is worth it imo.

❯ hyperfine -i -p 'rm -rf node_modules/' '../../d7/target/release/deno cache npm:@11ty/eleventy' 'deno cache npm:@11ty/eleventy'
Benchmark 1: ../../d7/target/release/deno cache npm:@11ty/eleventy
  Time (mean ± σ):     115.4 ms ±   1.2 ms    [User: 27.2 ms, System: 87.3 ms]
  Range (min … max):   113.7 ms … 117.5 ms    10 runs

Benchmark 2: deno cache npm:@11ty/eleventy
  Time (mean ± σ):     619.3 ms ±   6.4 ms    [User: 34.3 ms, System: 575.6 ms]
  Range (min … max):   612.2 ms … 633.3 ms    10 runs

Summary
  ../../d7/target/release/deno cache npm:@11ty/eleventy ran
    5.37 ± 0.08 times faster than deno cache npm:@11ty/eleventy

[littledivy]

There is a similar optimization for cp and copyFile APIs. It uses rayon for recursive clonefile and has some other optimizations for small files and fallbacks:

deno/ext/fs/std_fs.rs

Line 511 in b21004b

fn cp(from: &Path, to: &Path) -> FsResult<()> {

Maybe could be reused?

[dsherret]

I'm not sure we should use rayon in non-js sync specific scenarios. I feel like that might make stuff slower by using another thread pool.

[nathanwhit]

Gave it a shot anyway, no performance difference but I found it caused a failure when the destination is a directory that already exists - didn't dig into it but seems like something wasn't getting copied over properly (the panic is from setting up the bin entries – the origin file we're trying to symlink doesn't exist)

thread 'main' panicked at cli/npm/managed/resolvers/local/bin_entries.rs:89:48:
called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }

[littledivy]

LGTM, just two comments

[lucacasonato]

@dsherret ptal if this looks good to you

[marvinhagemeister]

Looking forward to this as a mac user 🚀

[dsherret]

Nice!

It doesn't have the space savings that comes with hardlinking, but the performance difference is worth it imo.

Agree. Storage is cheap.