fix(coverage): handle ignore patterns #23974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinhagemeister
approved these changes
May 24, 2024
dsherret
approved these changes
May 27, 2024
| let url = Url::parse(&new_coverage.url)?; | ||
| if exclude_patterns.matches_specifier(&url) { | ||
| coverages.push(new_coverage); | ||
| } |
There was a problem hiding this comment.
I got confused thinking that this condition should be flipped. Maybe we should rename exclude_patterns to something else? coverage_patterns maybe?
There was a problem hiding this comment.
Ah, right. coverage_patterns sounds better. Updated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--ignorepattern is currently matched against the coverage raw data path (<UUID>.json) and doesn't work as ignore pattern.This PR adds the path pattern checks against
urlproperty of each json object, and excludes the ignored patterns correctly.closes #23972