fix: use hash of in-memory bytes only for code cache #23966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
May 23, 2024
| ) -> Option<Vec<u8>> { | ||
| self.get_sync(specifier, code_cache_type, source_hash) | ||
| } | ||
|
|
||
| fn set_sync( | ||
| &self, | ||
| specifier: &str, | ||
| specifier: ModuleSpecifier, |
There was a problem hiding this comment.
deno_core was changed for this to be owned because it already had an owned value it no longer needed and this may allow us in the future to send this to another thread and skip a clone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did benchmarking on this and it's slightly faster (couple ms) or equal to in performance as main.
Closes #23904