chore(lsp): Print out stack trace if exception occurs in TS request #23543

nathanwhit · 2024-04-24T19:00:00Z

Before this PR, there would just be an uninformative "Error occurred" message, after this PR you'll get a stack trace in the LSP output window like this:

Error during TS request "$getSupportedCodeFixes":
  Error: i threw an exception
    at serverRequest (ext:deno_tsc/99_main_compiler.js:1089:11)

cli/lsp/tsc.rs

nathanwhit added 2 commits April 24, 2024 14:54

Print out stack trace if exception occurs in TS

8a11574

Tweak message a bit

0db37af

nathanwhit force-pushed the lsp-tsc-stack-trace branch from d0c54fe to 0db37af Compare April 24, 2024 19:03

bartlomieju reviewed Apr 24, 2024

View reviewed changes

cli/lsp/tsc.rs Outdated Show resolved Hide resolved

Remove commented out code

a163afa

bartlomieju approved these changes Apr 24, 2024

View reviewed changes

nathanwhit enabled auto-merge (squash) April 24, 2024 19:44

nathanwhit merged commit a6c2472 into denoland:main Apr 24, 2024
17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(lsp): Print out stack trace if exception occurs in TS request #23543

chore(lsp): Print out stack trace if exception occurs in TS request #23543

nathanwhit commented Apr 24, 2024 •

edited

chore(lsp): Print out stack trace if exception occurs in TS request #23543

chore(lsp): Print out stack trace if exception occurs in TS request #23543

Conversation

nathanwhit commented Apr 24, 2024 • edited

nathanwhit commented Apr 24, 2024 •

edited