perf(lsp): Call serverRequest via V8 instead of via executeScript
#23409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
reviewed
Apr 16, 2024
nathanwhit
force-pushed
the
lsp-server-request-opt
branch
from
60f45fd
to
6e1786a
Compare
|
Re-posting for visibility: maybe we could have a giant enum that you send over the channel and perform direct v8 serialization in the TSC thread? |
nathanwhit
force-pushed
the
lsp-server-request-opt
branch
from
904381d
to
b5c4107
Compare
bartlomieju
reviewed
Apr 17, 2024
cli/lsp/tsc.rs
Outdated
| ) -> Result<(&'static str, Option<v8::Local<'s, v8::Value>>), AnyError> { | ||
| let args = match self { | ||
| TscRequest::ProjectChanged(args) => { | ||
| ("$projectChanged", Some(serde_v8::to_v8(scope, args)?)) |
There was a problem hiding this comment.
Suggestion: consider giving these a numeric ID that you then map back in 99_compiler_main.js - it's gonna be faster than having to serialize these strings, but it's gonna be a bit wonky to keep track of them. Might be worth the trade-off 🤞
There was a problem hiding this comment.
We could do something like this to make it more robust to maintain a numeric mapping:
- Use
enum_deriveor something like it to derive an iterator for all variants on the Rust side. - Keep an enum in JS with the numeric mappings in some sort of object form (ie: easily converted to a string with the names and values):
enum TscRequest {
requestA = 0,
requestB,
...
}
- Have a callback that requests the full contents of that enum, only used for a unit test in the next step
- Have a unit test on the CLI/LSP side that compares whether the JS enum and Rust enums is up-to-date or not.
bartlomieju
approved these changes
Apr 19, 2024
nathanwhit
force-pushed
the
lsp-server-request-opt
branch
from
b5c4107
to
5952f33
Compare
nathanwhit
force-pushed
the
lsp-server-request-opt
branch
from
5952f33
to
ed8d8d3
Compare
nathanwhit
added a commit
that referenced
this pull request
May 2, 2024
…or TS result upon cancellation (#23645) Fixes #23643. We weren't catching the cancellation exception thrown by TSC on the JS side, so the rust side was catching this exception and then attempting to print out the exception via `toString`. That last bit resulted in a cryptic `[object Object]` showing up in the logs like so: ``` Error during TS request "getCompletionEntryDetails": [object Object] ``` I'm not 100% sure how we weren't seeing this in the past. My guess is that #23409 and the subsequent PR to improve the exception catching and logging surfaced this, but I'm still not quite clear on it. My initial fix here returned `null` to rust when a server request was cancelled, but this resulted in a deserialization error when we attempted to deserialize that into the expected response type. So now, as soon as the request's cancellation token signals we'll stop waiting for a response and return an error (which will get swallowed as the LSP request is being cancelled). I was a bit surprised to find that [this branch](https://github.com/nathanwhit/deno/blob/0c671c9792ac706c1ecd60f88efdc5eb8e941917/cli/lsp/tsc.rs#L1093) actually executes sometimes, I believe due to the fact that aborting a future may not [immediately stop its execution](https://docs.rs/futures/latest/futures/stream/struct.AbortHandle.html#method.abort).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't have a noticeable perf impact from my benchmarking, but theoretically should be better.