Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(publish): check specifiers outside fast check module graph #23369

Merged
merged 6 commits into from
Apr 17, 2024
Merged

test(publish): check specifiers outside fast check module graph #23369

merged 6 commits into from
Apr 17, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Apr 15, 2024

Closes #23023

@iuioiua iuioiua requested a review from dsherret April 15, 2024 06:41
@iuioiua iuioiua changed the title test(publish): check exports outside fast check module graph test(publish): check specifiers outside fast check module graph Apr 15, 2024
@iuioiua iuioiua mentioned this pull request Apr 16, 2024
Closed
@iuioiua iuioiua marked this pull request as ready for review April 16, 2024 23:34
dsherret
dsherret approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iuioiua iuioiua enabled auto-merge (squash) April 16, 2024 23:46
@iuioiua iuioiua merged commit 25a80bc into denoland:main Apr 17, 2024
17 checks passed
@iuioiua iuioiua deleted the fix-23023 branch April 18, 2024 11:12
littledivy pushed a commit to littledivy/deno that referenced this pull request Apr 19, 2024
@iuioiua @littledivy
test(publish): check specifiers outside fast check module graph (deno…
9c1a659 
…land#23369)

Closes denoland#23023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@iuioiua @dsherret