Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUTURE(ext/net): remove Deno.ListenTlsOptions.(keyFile|certFile) #23271

Merged
merged 12 commits into from
Apr 21, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Apr 7, 2024

Towards #23089

ext/net/02_tls.js Outdated Show resolved Hide resolved
@iuioiua iuioiua requested a review from bartlomieju April 9, 2024 02:19
@iuioiua
Copy link
Collaborator Author

iuioiua commented Apr 9, 2024

This passes on my local machine. Not sure why it's failing in CI.

@iuioiua iuioiua marked this pull request as draft April 10, 2024 22:02
@iuioiua
Copy link
Collaborator Author

iuioiua commented Apr 10, 2024

@mmastrac, I'm setting the deprecated cert and key properties to undefined if DENO_FUTURE=1 is being used. Now, we're panicking because we're hitting

unreachable!()
. Seeing as you made some changes around here in #23296, how do you suggest we handle this? Perhaps, instead of returning op_tls_key_null() in loadTlsKeyPair(), we could throw some error saying that none of the cert or key properties aren't defined but need to be. This will also affect #23270.

@iuioiua iuioiua marked this pull request as ready for review April 10, 2024 22:31
@iuioiua iuioiua changed the title FUTURE(ext/net): make Deno.ListenTlsOptions.(keyFile|certFile) illegal FUTURE(ext/net): remove Deno.ListenTlsOptions.(keyFile|certFile) Apr 18, 2024
@bartlomieju bartlomieju added this to the 1.43 milestone Apr 19, 2024
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please rebase

@iuioiua iuioiua enabled auto-merge (squash) April 20, 2024 23:34
@iuioiua iuioiua merged commit 98e2f6d into denoland:main Apr 21, 2024
17 checks passed
@iuioiua iuioiua deleted the future-listentls-options branch April 21, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants