FUTURE(ext/net): remove Deno.(Conn|TlsConn|Listener|TlsListener|UnixConn).prototype.rid
#23219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Conn).prototype.rid`
10 tasks
iuioiua
commented
Apr 3, 2024
ext/net/01_net.js
Outdated
| if (internals.future) { | ||
| ObjectDefineProperty(this, "rid", { value: undefined }); | ||
| } | ||
| ObjectDefineProperty(this, internalRidSymbol, { value: rid }); |
There was a problem hiding this comment.
Minor cleanup: enumerable property is false by default. Ditto elsewhere.
| enumerable: false, | ||
| value: rid, | ||
| }); | ||
| if (internals.future) { |
There was a problem hiding this comment.
Note: this change also takes care of TlsConn and UnixConn due to inheritance.
| enumerable: false, | ||
| value: rid, | ||
| }); | ||
| if (internals.future) { |
There was a problem hiding this comment.
Note: this also takes care of TlsListener due to inheritance.
bartlomieju
reviewed
Apr 4, 2024
bartlomieju
reviewed
Apr 4, 2024
|
Prerequisite #23220 |
Signed-off-by: Asher Gomez <[email protected]>
Signed-off-by: Asher Gomez <[email protected]>
satyarohith
pushed a commit
that referenced
this pull request
Apr 11, 2024
…Conn).prototype.rid` (#23219) Towards #23089 --------- Signed-off-by: Asher Gomez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #23089