feat(unstable): --unstable-* flags are only available in runtime subcommands #23063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
commented
Mar 24, 2024
Comment on lines
+3926
to
+3931
| // TODO(bartlomieju): these flags might actually be used in non-runtime subcommands | ||
| flags.unstable_config.bare_node_builtins = | ||
| matches.get_flag("unstable-bare-node-builtins"); | ||
| flags.unstable_config.byonm = matches.get_flag("unstable-byonm"); | ||
| flags.unstable_config.sloppy_imports = | ||
| matches.get_flag("unstable-sloppy-imports"); |
There was a problem hiding this comment.
I wasn't wrong, failing tests:
check::test_unstable_sloppy_imports_dts_files
publish::bare_node_builtins
publish::bare_node_builtins_warning_no_warnings
publish::sloppy_imports
publish::sloppy_imports_no_warnings
watcher::lint_all_files_on_each_change_test
Will need to split it into unstable_runtime_args and unstable_cli_flags - the latter should be applied to most of the subcommands (but not all!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes
--unstable-*flags only available in the runtime subcommands.Previously
--unstable-*flags were available globally, polluting help output for every singlesubcommand, even ones that did not use them.
This is most likely a Deno 2 change as it will break some of the existing CLI invocations - TBD.
We might want to enable it now with
DENO_FUTURE=1env var.