Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ext/node): use worker ops directly in worker_threads #22794

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

satyarohith
Copy link
Member

@satyarohith satyarohith commented Mar 8, 2024

Addresses [1] mentioned in #22783

Comment on lines 4 to 5
// TODO(petamoriken): enable prefer-primordials for node polyfills
// deno-lint-ignore-file prefer-primordials
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this ignore comment?

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satyarohith satyarohith enabled auto-merge (squash) March 8, 2024 14:35
@satyarohith satyarohith merged commit d5b01e4 into main Mar 8, 2024
17 checks passed
@satyarohith satyarohith deleted the copy_worker_code_to_worker_threads branch March 8, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants