fix(ext/node): allow automatic worker_thread termination #22647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this issue! But just a small remark concerning the questionable standard compliant behavior of Even if you add this code fragment: the application will not stop! It will get the |
|
This whole issue looks close related to #14318 |
mmastrac
reviewed
Mar 1, 2024
mmastrac
reviewed
Mar 1, 2024
bartlomieju
reviewed
Mar 12, 2024
|
FYI: #22826 is a pre-requisite for this PR. cc @bartlomieju |
bartlomieju
approved these changes
Mar 13, 2024
nathanwhit
pushed a commit
that referenced
this pull request
Mar 14, 2024
Co-authored-by: Matt Mastracci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes node_worker to auto exit after script execution is completed. It doesn't update Deno worker behaviour as the spec expects users to manually terminate the web worker.
Closes #22629