Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: disable test-fs-watchfile.js on Mac ARM #22209

Merged
merged 5 commits into from
Jan 31, 2024
Merged

chore: disable test-fs-watchfile.js on Mac ARM #22209

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
78af229
chore: disable test-fs-watchfile.js on Mac ARM
bartlomieju Jan 31, 2024
9455e1e
Merge branch 'main' into disable_flaky_test
bartlomieju Jan 31, 2024
fcb7467
add to ignore
bartlomieju Jan 31, 2024
e8148a9
fix?
bartlomieju Jan 31, 2024
4cc1773
reset CI
bartlomieju Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix?
  • Loading branch information
@bartlomieju
bartlomieju committed Jan 31, 2024
commit e8148a9db2a528ec52bd279361153ca704ec9ac6
4 changes: 2 additions & 2 deletions cli/tests/node_compat/config.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@
"test-fs-rmdir-recursive.js",
"test-fs-write-file.js",
"test-fs-write.js",
"test-fs-watchfile.js",
"test-http-url.parse-https.request.js",
"test-net-better-error-messages-path.js",
"test-net-connect-buffer.js",
Expand Down Expand Up @@ -728,7 +727,8 @@
"darwinIgnore": {
"parallel": [
"test-net-allow-half-open.js",
"test-net-socket-close-after-end.js"
"test-net-socket-close-after-end.js",
"test-fs-watchfile.js"
]
},
"suitesFolder": "test",
Expand Down
2 changes: 1 addition & 1 deletion cli/tests/node_compat/test/parallel/test-fs-watchfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ watcher.on('stop', common.mustCall());

// Watch events should callback with a filename on supported systems.
// Omitting AIX. It works but not reliably.
if (common.isLinux || (common.isOSX && process.arch !== "arm64") || common.isWindows) {
if (common.isLinux || common.isOSX || common.isWindows) {
const dir = path.join(tmpdir.path, 'watch');

fs.mkdir(dir, common.mustCall(function(err) {
Expand Down
Loading