Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: point to new "Deno 1.x to 2.x Migration Guide" #22199

Merged
merged 6 commits into from
Feb 2, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jan 31, 2024

This change reworks deprecation notices to point to the new Deno 1.x to 2.x Migration Guide.

Prerequisite denoland/deno-docs#300

@iuioiua
Copy link
Collaborator Author

iuioiua commented Jan 31, 2024

@bartlomieju, please let me know if you like the new format. Once confirmed, I'll copy/paste the change to the rest of the deprecated APIs.

@iuioiua
Copy link
Collaborator Author

iuioiua commented Feb 1, 2024

Shall I modify this to only touch JSDocs?

@bartlomieju
Copy link
Member

Shall I modify this to only touch JSDocs?

  • update warnOnDeprecatedApi to print this message as a last hint

@iuioiua iuioiua marked this pull request as ready for review February 1, 2024 02:40
runtime/js/99_main.js Outdated Show resolved Hide resolved
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@bartlomieju bartlomieju merged commit 3f4639c into denoland:main Feb 2, 2024
15 checks passed
@iuioiua iuioiua deleted the point-migration-guide branch February 2, 2024 01:36
bartlomieju pushed a commit that referenced this pull request Feb 7, 2024
littledivy pushed a commit that referenced this pull request Feb 8, 2024
littledivy pushed a commit that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants