Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove imported ops from Deno.core.ops #22194

Merged
merged 11 commits into from
Jan 31, 2024
Merged

refactor: remove imported ops from Deno.core.ops #22194

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6ec50e0
refactor: remove imported ops from Deno.core.ops
bartlomieju Jan 30, 2024
0fd0b54
add a unit test
bartlomieju Jan 30, 2024
b9b8215
update the test
bartlomieju Jan 30, 2024
63d2cab
Merge branch 'main' into remove_imported_ops
bartlomieju Jan 30, 2024
7282e63
lint
bartlomieju Jan 30, 2024
3e50a1f
reset CI
bartlomieju Jan 30, 2024
bf8b313
fix tests
bartlomieju Jan 30, 2024
aa7a256
fix tests2
bartlomieju Jan 30, 2024
561668c
ops test
bartlomieju Jan 30, 2024
c8db6be
napi
bartlomieju Jan 30, 2024
d1fb390
Merge branch 'main' into remove_imported_ops
bartlomieju Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update the test
  • Loading branch information
@bartlomieju
bartlomieju committed Jan 30, 2024
commit b9b821547b7b8d9a48739ba8f124ef73b8c62ac8
8 changes: 6 additions & 2 deletions cli/tests/unit/ops_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.

const EXPECTED_OP_COUNT = 151;

Deno.test(function checkExposedOps() {
// @ts-ignore TS doesn't allow to index with symbol
const core = Deno[Deno.internal].core;
const opNames = Object.keys(core.ops);

if (opNames.length !== 200) {
if (opNames.length !== EXPECTED_OP_COUNT) {
throw new Error(
`Expected 200 ops, but got ${opNames.length}:\n${opNames.join("\n")}`,
`Expected ${EXPECTED_OP_COUNT} ops, but got ${opNames.length}:\n${
opNames.join("\n")
}`,
);
}
});
Loading
Loading