fix(lockfile): only consider package.json beside lockfile in workspace property #22179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jan 30, 2024
| .skip_output_check(); | ||
| // the lockfile should stay the same as the above because the package.json | ||
| // was found in a different directory | ||
| lockfile.assert_matches_json(expected_lockfile.clone()); |
There was a problem hiding this comment.
Previously this would flip flop back and forth between the packages from package.json and packages-a/package.json. Now it just stays being the ones in package.json. In the future, we should get deno to understand npm workspaces beyond just for byonm and then it could include all the members in the lockfile (luckily the lockfile code already has support for this... it's just getting it into the CLI sometime).
bartlomieju
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22176 (see detail there)