feat(node): add ppid getter for node:process
#22167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Jan 29, 2024
cli/tests/unit_node/process_test.ts
Outdated
Comment on lines
128
to
131
| // TODO(magurotuna): Deno.ppid now is of type bigint (although its type | ||
| // declaration says it's a number). Until it's fixed, we compare | ||
| // `process.ppid` with the casted value. | ||
| // https://github.com/denoland/deno/issues/22166 |
There was a problem hiding this comment.
Probably can be removed now?
bartlomieju
approved these changes
Jan 30, 2024
littledivy
pushed a commit
that referenced
this pull request
Feb 1, 2024
This commit adds `ppid` getter for `node:process` to improve Node compatibility one step further. There is one problem though, which is that `Deno.ppid`, which `process.ppid` internally calls, is actually of type `bigint` although it's supposed to be `number`. I filed an issue for this (#22166). For the time being, explciit type conversion from `bigint` to `number` is applied to match the Node.js behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
ppidgetter fornode:processto improve Node compatibility one step further.There is one problem though, which is that
Deno.ppid, whichprocess.ppidinternally calls, is actually of typebigintalthough it's supposed to benumber. I filed an issue for this (#22166). For the time being, explciit type conversion frombiginttonumberis applied to match the Node.js behavior.