fix(ext/node): fix no arg call of fs.promises.readFile #22030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
force-pushed
the
fix-fs-promises-read-file-no-arg
branch
from
2f009e4
to
16afaf9
Compare
kt3k
force-pushed
the
fix-fs-promises-read-file-no-arg
branch
from
16afaf9
to
8e32e99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
util.promisifyfor creatingfs.promises.readFile, but that doesn't support the case when it's called with no args (With no arg call, promisify passes the callback as the first arg offs.readFile, and that is not supported). As reported in #21795, isomorphic-git usesfs.promises.readFile()for checking the availability offs.promises, and that causes an uncaught error.This PR fixes the above by avoiding to use
promisify, but using more primitive wrapper structure for creating promise version ofreadFile.See also the comment #21795 (comment)
closes #21795