fix(config): regression - handle relative patterns with leading dot slash #21922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .with_context(|| format!("Failed to expand glob: \"{}\"", pattern))?; | ||
| let pattern = escape_brackets(pattern) | ||
| .replace('\\', "/") | ||
| .replace("/./", "/"); |
There was a problem hiding this comment.
Wouldn't it be better to construct each time the absolute path from the relative path instead of building a relative path compliant pattern?
I do not know what is the exact expected usage of that glob expansion code but that does not look right to do path munging in code dedicated to glob handling.
There was a problem hiding this comment.
Yeah that's what's done in the real fix in #21925
It requires a much larger and riskier refactor to do that though (as seen there)
bartlomieju
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hacky quick fix. We need to spend more time cleaning up this code and push more stuff down into deno_config.
Closes #21916