Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(task): do not eagerly auto-install packages in package.json when "nodeModulesDir": false #21858

Merged

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jan 8, 2024

There's no need to auto-install the package.json if the user is not using a node_modules directory.

Closes #21850

@dsherret dsherret changed the title fix(task): do not auto-install packages when "nodeModulesDir": false fix(task): do not eagerly auto-install packages when "nodeModulesDir": false Jan 8, 2024
@dsherret dsherret changed the title fix(task): do not eagerly auto-install packages when "nodeModulesDir": false fix(task): do not eagerly auto-install packages in package.json when "nodeModulesDir": false Jan 8, 2024
@dsherret dsherret merged commit be888c0 into denoland:main Jan 9, 2024
14 checks passed
@dsherret dsherret deleted the fix_task_auto_install_node_modules_dir branch January 9, 2024 00:30
bartlomieju pushed a commit that referenced this pull request Jan 12, 2024
…`"nodeModulesDir": false` (#21858)

There's no need to auto-install the package.json if the user is not
using a node_modules directory.

Closes #21850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno task auto-installs package.json even when nodeModulesDir: false
2 participants