Make Deno/Deno.core not deletable/writable

[kevinkassimo]

before:

> Deno = 1
1
panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `0`', ../../core/isolate.rs:468:7
Abort trap: 6

> delete window.Deno
true
panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `0`', ../../core/isolate.rs:468:7
Abort trap: 6

> Deno.core.send = 1
1
panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `0`', ../../core/isolate.rs:468:7
Abort trap: 6

> delete Deno.core.send
true
panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `0`', ../../core/isolate.rs:468:7
Abort trap: 6

after:

> Deno = 1
1
> delete window.Deno
false
> Deno.core.send = 1
1
> delete Deno.core.send
false
> Deno
{ args, noColor, pid, env, exit, isTTY, execPath, chdir, cwd, File, open, openSync, stdin, stdout, stderr, read, readSync, write, writeSync, seek, seekSync, close, copy, toAsyncIterator, SeekMode, Buffer, readAll, readAllSync, mkdirSync, mkdir, makeTempDirSync, makeTempDir, chmodSync, chmod, removeSync, remove, renameSync, rename, readFileSync, readFile, readDirSync, readDir, copyFileSync, copyFile, readlinkSync, readlink, statSync, lstatSync, stat, lstat, linkSync, link, symlinkSync, symlink, writeFileSync, writeFile, ErrorKind, DenoError, permissions, revokePermission, truncateSync, truncate, connect, dial, listen, metrics, resources, run, Process, inspect, build, platform, version, core, Console, stringifyArgs, DomIterableMixin }
> Deno.core.send
[Function]
>

[ry]

Maybe os.start() is a better place for this? I think this won't get called for workers.

[kevinkassimo]

Actually denoMain() is still called in user-created workers:

deno/cli/ops.rs

Lines 1878 to 1881 in 0796a8f

	let mut worker =
	Worker::new(name, startup_data::deno_isolate_init(), child_state);
	js_check(worker.execute("denoMain()"));
	js_check(worker.execute("workerMain()"));

but yeah putting it in os.start() sound better since we also call core.setAsyncHandler(handleAsyncMsgFromRust); for core-related initialization.

[ry]

👍

[ry]

LGTM

[cybor0]

Hi shuldn't this freeze be deeply
What with Deno.ErrorKind.IdnaError = "blabla" Deno.platform.arch="blabla"

[kevinkassimo]

@cybor0 The major purposes of this PR is to avoid user messing up with the message passing mechanism of deno. We should probably also freeze these values, but it could be a separate PR and would be great if you want to work on this.

[cybor0]

@kevinkassimo I understand your point of view. Maybe later in the future i will help.