Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bench_util): fix syntax error in README.md #21492

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

zhanghengxin
Copy link
Contributor

fix:Updating grammar errors in readme.md

fix #21491

@CLAassistant
Copy link

CLAassistant commented Dec 7, 2023

CLA assistant check
All committers have signed the CLA.

@dsherret dsherret changed the title fix(bench_util doc):Updating grammar errors in readme.md chore(bench_util): fix syntax error in README.md Dec 7, 2023
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhanghengxin Thanks! Once the CLA is signed then we can merge this.

@zhanghengxin
Copy link
Contributor Author

@dsherret

The signing has been completed as requested.

@zhanghengxin
Copy link
Contributor Author

@dsherret
What are the other things I need to do?

@dsherret
Copy link
Member

@zhanghengxin I think just run ./tools/format.js and it should be good to go. That code block has started being formatted by the formatter now that it doesn't contain a syntax error.

@zhanghengxin
Copy link
Contributor Author

@zhanghengxin I think just run ./tools/format.js and it should be good to go. That code block has started being formatted by the formatter now that it doesn't contain a syntax error.我认为只要跑一跑 ./tools/format.js ,它应该很好。该代码块已开始由格式化程序格式化,因为它不包含语法错误。

Because it is code in Markdown, nobody corrected it for two years.

@dsherret
Copy link
Member

The CI for this PR is failing because the code is not formatted. Running ./tools/format.js then committing the changes will fix it and make the CI pass.

@zhanghengxin
Copy link
Contributor Author

sorry , I misunderstood the meaning.I got to do!

zhanghengxin and others added 3 commits January 30, 2024 11:14
fix:Updating grammar errors in readme.md

Signed-off-by: zhanghengxin <[email protected]>
@zhanghengxin
Copy link
Contributor Author

image
image

Nothing changed after the formatting was performed

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit b0bd4f3 into denoland:main Jan 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to update syntax errors in bench_util/readme.md
4 participants