chore: bump deno_core and update tests #21467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
changed the title
mmastrac
force-pushed
the
deno_core_bump
branch
from
6e322e8
to
ab36d6c
Compare
mmastrac
commented
Dec 5, 2023
mmastrac
commented
Dec 5, 2023
| @@ -4,4 +4,5 @@ console.log("Starting the child worker"); | |||
|
|
|||
| setTimeout(() => { | |||
| console.log("The child worker survived the death of the parent!!!"); | |||
| Deno.exit(1); | |||
There was a problem hiding this comment.
Avoids the test spinning forever if it fails
mmastrac
commented
Dec 5, 2023
| @@ -9,25 +9,6 @@ use deno_core::error::JsError; | |||
| use deno_core::error::JsStackFrame; | |||
| use std::fmt::Write as _; | |||
|
|
|||
| /// Compares all properties of JsError, except for JsError::cause. | |||
mmastrac
commented
Dec 6, 2023
| @@ -182,6 +182,7 @@ impl WebWorkerInternalHandle { | |||
| /// This function will set terminated to true, terminate the isolate and close the message channel | |||
| pub fn terminate(&mut self) { | |||
| self.cancel.cancel(); | |||
| self.terminate_waker.wake(); | |||
There was a problem hiding this comment.
Discovered this was necessary with @bartlomieju
bartlomieju
reviewed
Dec 6, 2023
cli/tests/testdata/run/with_package_json/no_deno_json/noconfig.out
Outdated
Show resolved
Hide resolved
| @@ -4,4 +4,5 @@ console.log("Starting the child worker"); | |||
|
|
|||
| setTimeout(() => { | |||
| console.log("The child worker survived the death of the parent!!!"); | |||
| Deno.exit(1); | |||
Comment on lines
-405
to
-416
| // Add a callback for "error" event - it will be dispatched | ||
| // if error is thrown during dispatch of "unhandledrejection" | ||
| // event. | ||
| globalThis_.addEventListener("error", errorEventCb); | ||
| globalThis_.dispatchEvent(rejectionEvent); | ||
| globalThis_.removeEventListener("error", errorEventCb); | ||
|
|
||
| // If event was not yet prevented, try handing it off to Node compat layer | ||
| // (if it was initialized) | ||
| if ( | ||
| !rejectionEvent.defaultPrevented && | ||
| typeof internals.nodeProcessUnhandledRejectionCallback !== "undefined" |
There was a problem hiding this comment.
Good to see so much complexity removed. Pinging @igorzi and @satyarohith that you will need to update this bit on your side as well.
mmastrac
commented
Dec 6, 2023
mmastrac
changed the title
mmastrac
force-pushed
the
deno_core_bump
branch
from
b5e12db
to
d49dd37
Compare
bartlomieju
approved these changes
Dec 6, 2023
|
/bench http[minimal,realistic] |
http[minimal]
http[realistic]
start: id: server: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Landing changes required for denoland/deno_core#359
We need to update 99_main.js and a whole load of tests.
API changes: