feat(unstable): ability to resolve specifiers with no extension, specifiers for a directory, and TS files from JS extensions #21464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Dec 5, 2023
cli/args/flags.rs
Outdated
| @@ -447,6 +447,7 @@ pub struct Flags { | |||
| pub unstable: bool, | |||
| pub unstable_bare_node_builtins: bool, | |||
| pub unstable_byonm: bool, | |||
| pub unstable_loose_imports: bool, | |||
There was a problem hiding this comment.
Alternative name to further discourage use: --unstable-sloppy-imports
There was a problem hiding this comment.
I like sloppy imports.
unstable-chaotic-imports?
unstable-messy-imports?
unstable-reckless-imports ?
unstable-naughty-imports?
There was a problem hiding this comment.
I also like --unstable-sloppy-imports better.
|
This should be good to go now. I'll add the functionality for the informative error messages when not using this flag in a separate PR. |
bartlomieju
approved these changes
Dec 6, 2023
Comment on lines
+1199
to
+1218
| fn specifier_text_for_redirected( | ||
| redirect: &lsp::Url, | ||
| referrer: &lsp::Url, | ||
| ) -> String { | ||
| if redirect.scheme() == "file" && referrer.scheme() == "file" { | ||
| // use a relative specifier when it's going to a file url | ||
| match referrer.make_relative(redirect) { | ||
| Some(relative) => { | ||
| if relative.starts_with('.') { | ||
| relative | ||
| } else { | ||
| format!("./{}", relative) | ||
| } | ||
| } | ||
| None => redirect.to_string(), | ||
| } | ||
| } else { | ||
| redirect.to_string() | ||
| } | ||
| } |
This was referenced Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
--unstable-sloppy-importsflag which supports the following forfile:specifiers:./modin a specifier to do extension probing.import { Example } from "./example"instead ofimport { Example } from "./example.ts"./routesto do directory extension probing for files like./routes/index.ts./mod.jsfor mod.ts files.This functionality is NOT RECOMMENDED for general use with Deno:
This is instead only recommended to help with migrating existing projects to Deno. For example, it's very useful for getting CJS projects written with import/export declaration working in Deno without modifying module specifiers and for supporting TS ESM projects written with
./mod.jsspecifiers.This feature will output warnings to guide the user towards correcting their specifiers. Additionally, Quick fixes are provided in the LSP to update these specifiers: