Self review

cli/tests/unit_node/fs_test.ts

@@ -48,15 +48,15 @@ Deno.test(
 Deno.test(
   "[node/fs existsSync] path",
   { permissions: { read: true } },
-  function () {
+  () => {
     assert(existsSync("cli/tests/testdata/assets/fixture.json"));
   },
 );
 
 Deno.test(
   "[node/fs existsSync] url",
   { permissions: { read: true } },
-  function () {
+  () => {
     assert(existsSync(
       pathToAbsoluteFileUrl("cli/tests/testdata/assets/fixture.json"),
     ));
@@ -66,7 +66,7 @@ Deno.test(
 Deno.test(
   "[node/fs existsSync] no permission",
   { permissions: { read: false } },
-  function () {
+  () => {
     assertThrows(() => {
       existsSync("cli/tests/testdata/assets/fixture.json");
     }, Deno.errors.PermissionDenied);
@@ -76,7 +76,7 @@ Deno.test(
 Deno.test(
   "[node/fs existsSync] not exists",
   { permissions: { read: true } },
-  function () {
+  () => {
     assert(!existsSync("bad_filename"));
   },
 );

ext/node/lib.rs

@@ -51,9 +51,9 @@ pub trait NodePermissions {
     api_name: &str,
   ) -> Result<(), AnyError>;
   fn check_read(&self, path: &Path) -> Result<(), AnyError> {
-    self.check_read_api(path, None)
+    self.check_read_with_api_name(path, None)
   }
-  fn check_read_api(
+  fn check_read_with_api_name(
     &self,
     path: &Path,
     api_name: Option<&str>,
@@ -71,7 +71,7 @@ impl NodePermissions for AllowAllNodePermissions {
   ) -> Result<(), AnyError> {
     Ok(())
   }
-  fn check_read_api(
+  fn check_read_with_api_name(
     &self,
     _path: &Path,
     _api_name: Option<&str>,

ext/node/ops/fs.rs

@@ -20,7 +20,7 @@ where
   let path = PathBuf::from(path);
   state
     .borrow_mut::<P>()
-    .check_read_api(&path, Some("node:fs.existsSync()"))?;
+    .check_read_with_api_name(&path, Some("node:fs.existsSync()"))?;
   let fs = state.borrow::<FileSystemRc>();
   Ok(fs.lstat_sync(&path).is_ok())
 }

runtime/permissions/mod.rs

@@ -1376,7 +1376,7 @@ impl deno_node::NodePermissions for PermissionsContainer {
   }
 
   #[inline(always)]
-  fn check_read_api(
+  fn check_read_with_api_name(
     &self,
     path: &Path,
     api_name: Option<&str>,

runtime/snapshot.rs

@@ -76,7 +76,7 @@ impl deno_node::NodePermissions for Permissions {
   ) -> Result<(), deno_core::error::AnyError> {
     unreachable!("snapshotting!")
   }
-  fn check_read_api(
+  fn check_read_with_api_name(
     &self,
     _p: &Path,
     _api_name: Option<&str>,