feat(ext/fetch): allow Deno.HttpClient to be declared with using
#21453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magurotuna
force-pushed
the
http-client-dispose
branch
from
a6f9aaf
to
85be4b7
Compare
bartlomieju
reviewed
Dec 4, 2023
ext/fetch/22_http_client.js
Outdated
Comment on lines
42
to
44
| [SymbolDispose]() { | ||
| this.close(); | ||
| } |
There was a problem hiding this comment.
Shouldn't this be tryClose so it doesn't throw if someone explicitly calls close beforehand?
There was a problem hiding this comment.
It should! I fixed that and added a test case in 77e0ef2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a method of
Symbol.disposeto the object returned fromDeno.createHttpClient, so we can make use of explicit resource management by declaring it withusing.