Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: faster args for op_load in TSC #21438

Merged
merged 2 commits into from
Dec 3, 2023

Conversation

bartlomieju
Copy link
Member

This commit changes the argument that "op_load" accepts, from
a serde struct to "&str". This should equal to a slightly better performance.

Copy link
Collaborator

@nayeemrmn nayeemrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju enabled auto-merge (squash) December 3, 2023 01:52
@bartlomieju bartlomieju merged commit 39c7d8d into denoland:main Dec 3, 2023
14 checks passed
@bartlomieju bartlomieju deleted the tsc_op_load branch December 5, 2023 21:03
bartlomieju added a commit that referenced this pull request Dec 5, 2023
This commit changes the argument that "op_load" accepts, from
a serde struct to "&str". This should equal to a slightly better
performance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants