Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(lsp): fix redundant serialization of sources #21435

Merged
merged 1 commit into from
Dec 2, 2023
Merged

perf(lsp): fix redundant serialization of sources #21435

merged 1 commit into from
Dec 2, 2023

Conversation

nayeemrmn
Copy link
Collaborator

Our host.getScriptSnapshot() had not been populating the sourceFileCache.

bartlomieju
bartlomieju approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally, now we don't load all the files all the time.

This was referenced Dec 2, 2023
Open
Closed
@nayeemrmn nayeemrmn merged commit 0f990d9 into denoland:main Dec 2, 2023
14 checks passed
@nayeemrmn nayeemrmn deleted the lsp-tsc-source-cache branch December 3, 2023 17:53
bartlomieju pushed a commit that referenced this pull request Dec 5, 2023
@nayeemrmn @bartlomieju
perf(lsp): fix redundant serialization of sources (#21435)
14e9402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nayeemrmn @bartlomieju