Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: snapshotting of runtime/ and cli/ #21430

Merged
merged 5 commits into from
Dec 2, 2023
Merged

refactor: snapshotting of runtime/ and cli/ #21430

merged 5 commits into from
Dec 2, 2023

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Dec 2, 2023 •
edited
Loading

This commit removes some of the technical debt related
to snapshotting JS code:

  • "cli/ops/mod.rs" and "cli/build.rs" no longer define "cli" extension
    which was not required anymore
  • Cargo features for "deno_runtime" crate have been unified in "cli/Cargo.toml"
  • "cli/build.rs" uses "deno_runtime::snapshot::create_runtime_snapshot" API
    instead of copy-pasting the code
  • "cli/js/99_main.js" was completely removed as it's not necessary anymore

Towards #21137

littledivy
littledivy approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cli/Cargo.toml Outdated Show resolved Hide resolved
mmastrac
mmastrac approved these changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Divys suggestion

@bartlomieju bartlomieju enabled auto-merge (squash) December 2, 2023 23:18
@bartlomieju bartlomieju merged commit f6b889b into denoland:main Dec 2, 2023
14 checks passed
@bartlomieju bartlomieju deleted the cli_snapshot branch December 2, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac approved these changes

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bartlomieju @mmastrac @littledivy