Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): setting process.exitCode should change exit code of process #21429

Merged
merged 5 commits into from
Dec 2, 2023
Merged

fix(node): setting process.exitCode should change exit code of process #21429

merged 5 commits into from
Dec 2, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Dec 1, 2023

Closes #21424

@dsherret dsherret marked this pull request as draft December 1, 2023 21:34
@dsherret dsherret marked this pull request as ready for review December 2, 2023 01:04
littledivy
littledivy approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ext/node/polyfills/process.ts Outdated Show resolved Hide resolved
dsherret and others added 2 commits December 2, 2023 10:35
@dsherret @littledivy
Update ext/node/polyfills/process.ts
fbd6065 
Co-authored-by: Divy Srivastava <[email protected]>
Signed-off-by: David Sherret <[email protected]>
@dsherret
Add test
592a265
@dsherret dsherret enabled auto-merge (squash) December 2, 2023 15:39
@dsherret dsherret merged commit f29075a into denoland:main Dec 2, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

process.exitCode is not respected
2 participants
@dsherret @littledivy