perf(ext/napi): port NAPI to v8 tasks #21406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@littledivy This one seems to be working, but I need a bit of help coming up with a test plan to make sure that it works as expected. Do you know of a good npm package to test it with? |
|
@mmastrac https://www.npmjs.com/package/@parcel/watcher is a good one for testing thread safe functions. |
littledivy
reviewed
Dec 2, 2023
Comment on lines
+89
to
+92
| #[repr(transparent)] | ||
| struct SendPtr<T>(*const T); | ||
| unsafe impl<T> Send for SendPtr<T> {} | ||
| unsafe impl<T> Sync for SendPtr<T> {} |
There was a problem hiding this comment.
SendPtr from cli/napi/async.rs can be reused here?
| context: SendPtr<c_void>, | ||
| data: SendPtr<c_void>, | ||
| ) { | ||
| // SAFETY: We're calling the provided callback with valid args |
| ); | ||
|
|
||
| fn event_loop_middleware( |
Co-authored-by: Divy Srivastava <[email protected]> Signed-off-by: Matt Mastracci <[email protected]>
littledivy
added a commit
that referenced
this pull request
Dec 14, 2023
Pending review items from #21406
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of removing middleware.
This is somewhat awkward because
V8CrossThreadTaskSpawnerrequires tasks to beSend, but NAPI makes heavy use of!Sendpointers. In addition, Rust causes a closure to be!Sendif you pull a!Sendvalue out of a struct.