Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): allow null value for req.setHeader #21391

Merged
merged 3 commits into from
Dec 8, 2023
Merged

fix(ext/node): allow null value for req.setHeader #21391

merged 3 commits into from
Dec 8, 2023

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Nov 30, 2023

This PR updates req.setHeader of node:http and node:https. Now null value is allowed for value input of setHeader.

closes #21389

@kt3k
Copy link
Member Author

kt3k commented Dec 8, 2023

Oops, I missed CI error 😓 Thanks for fixing!

@kt3k kt3k merged commit 3a74fa6 into denoland:main Dec 8, 2023
14 checks passed
@kt3k kt3k deleted the fix-node-http-set-header branch December 8, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node:http(s): null value is not allowed for header value
2 participants
@kt3k @bartlomieju