fix(task): handle node_modules/.bin directory with byonm #21386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Nov 30, 2023
bartlomieju
reviewed
Dec 2, 2023
Comment on lines
+312
to
+314
| context | ||
| .new_command() | ||
| .args_vec(["task", "say"]) |
| ]; | ||
| args.extend(context.args); | ||
| let executable_command = | ||
| deno_task_shell::ExecutableCommand::new("deno".to_string()); |
There was a problem hiding this comment.
This will use the system deno binary and not the current binary?
There was a problem hiding this comment.
deno_task_shell has some code that will always make the "deno" command use the current executing binary (for the time being, the tests would fail if that weren't the case)
dsherret
commented
Dec 6, 2023
| @@ -213,6 +213,14 @@ pub struct RunFlags { | |||
| } | |||
|
|
|||
| impl RunFlags { | |||
| #[cfg(test)] | |||
| pub fn new_default(script: String) -> Self { | |||
There was a problem hiding this comment.
I kept this change because I think it will make things easier in the future if we ever add another flag to this sub command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit hacky, but it works. Essentially, this will checks for all the scripts in the node_modules/.bin directory then forces them to run with Deno via deno_task_shell.