fix(ext/node): fix node:stream.Writable #21297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Nov 22, 2023
crowlKats
pushed a commit
that referenced
this pull request
Nov 24, 2023
This change applies the same fix as nodejs/node#46818, and the original example given in #20456 works as expected. closes #20456 (cherry picked from commit bf42467)
bartlomieju
pushed a commit
that referenced
this pull request
Nov 24, 2023
This change applies the same fix as nodejs/node#46818, and the original example given in #20456 works as expected. closes #20456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
Writableofnode:streamhas an issue in handlingonConstructcallback. Whenwritable.writeis called at certain timing near the end ofwritable._construct, that chunk overtakes the chunks that are stored in the internal buffer ofwritable. See examples in #20456 for details.Node.js had a very similar (probably the same) issue nodejs/node#46765, and it was fixed by nodejs/node#46818.
This PR applies the same fix as nodejs/node#46818, and the original example given in #20456 works as expected.
closes #20456