refactor(upgrade): add unit tests for lsp upgrade check #21244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayeemrmn
approved these changes
Nov 17, 2023
zifeo
pushed a commit
to metatypedev/deno
that referenced
this pull request
Nov 22, 2023
bartlomieju
pushed a commit
that referenced
this pull request
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was investigating the flaky repl startups in #21187 and thinking it might be related to the upgrade check, but not sure. Anyway, I wanted to modify the upgrade code, but we didn't have any tests for it, so this is a refactor to get the upgrade code unit testable. After this, I'll open a separate PR sometime to add integration tests that use the test server (I realize I'm somewhat doing this backwards from recommended practice--should do integration tests first--but I've done some manually testing), then I'll change the behaviour.