ci: fix flaky stdio_streams_are_locked_in_permission_prompt #21238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Nov 17, 2023
| // expect in this scenario. If not, that would indicate a bug. | ||
| assert!(malicious_index < prompt_index); | ||
| return; | ||
| } |
There was a problem hiding this comment.
I tested this by adding an artificial delay between the two statements on line 4428.
dsherret
deleted the
ci_fix_flaky_stdio_streams_are_locked_in_permission_prompt
branch
zifeo
pushed a commit
to metatypedev/deno
that referenced
this pull request
Nov 22, 2023
bartlomieju
pushed a commit
that referenced
this pull request
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #21187