Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: lazy bootstrap options - first pass #21164

Merged
merged 10 commits into from
Nov 13, 2023
Merged

perf: lazy bootstrap options - first pass #21164

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
69ca03a
experiment: lazy bootstrap options
littledivy Nov 11, 2023
af50a91
Merge branch 'main' into lazy_bootstrap_1
littledivy Nov 11, 2023
676b25d
lint
littledivy Nov 11, 2023
1939a02
Merge branch 'lazy_bootstrap_1' of github.com:littledivy/deno into la…
littledivy Nov 11, 2023
e0df321
x
littledivy Nov 11, 2023
989a17e
Merge branch 'main' into lazy_bootstrap_1
littledivy Nov 11, 2023
80f3ce0
Merge branch 'main' into lazy_bootstrap_1
littledivy Nov 12, 2023
6a81fba
fix
littledivy Nov 12, 2023
e709fb5
rename to `memoizeLazy`
littledivy Nov 13, 2023
deeca49
fix
littledivy Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename to memoizeLazy
  • Loading branch information
@littledivy
littledivy committed Nov 13, 2023
commit e709fb5c8370a5368831004cc8d23979dbcacd76
8 changes: 4 additions & 4 deletions runtime/js/98_global_scope.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ class Navigator {

const navigator = webidl.createBranded(Navigator);

function makeLazy(f) {
function memoizeLazy(f) {
let v_ = null;
return () => {
if (v_ === null) {
Expand All @@ -168,9 +168,9 @@ function makeLazy(f) {
};
}

const numCpus = makeLazy(() => ops.op_bootstrap_numcpus());
const userAgent = makeLazy(() => ops.op_bootstrap_user_agent());
const language = makeLazy(() => ops.op_bootstrap_language());
const numCpus = memoizeLazy(() => ops.op_bootstrap_numcpus());
const userAgent = memoizeLazy(() => ops.op_bootstrap_user_agent());
const language = memoizeLazy(() => ops.op_bootstrap_language());

ObjectDefineProperties(Navigator.prototype, {
hardwareConcurrency: {
Expand Down
8 changes: 4 additions & 4 deletions runtime/js/99_main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ import * as webidl from "ext:deno_webidl/00_webidl.js";
import DOMException from "ext:deno_web/01_dom_exception.js";
import {
mainRuntimeGlobalProperties,
makeLazy,
memoizeLazy,
unstableWindowOrWorkerGlobalScope,
windowOrWorkerGlobalScope,
workerRuntimeGlobalProperties,
Expand Down Expand Up @@ -238,9 +238,9 @@ function opMainModule() {
return ops.op_main_module();
}

const opArgs = makeLazy(() => ops.op_bootstrap_args());
const opPid = makeLazy(() => ops.op_bootstrap_pid());
const opPpid = makeLazy(() => ops.op_ppid());
const opArgs = memoizeLazy(() => ops.op_bootstrap_args());
const opPid = memoizeLazy(() => ops.op_bootstrap_pid());
const opPpid = memoizeLazy(() => ops.op_ppid());
setNoColorFn(() => ops.op_bootstrap_no_color());

function formatException(error) {
Expand Down
Loading