fix(install): should work with non-existent relative root #21161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Nov 11, 2023
| @@ -1756,7 +1756,6 @@ These must be added to the path manually if required.") | |||
| Arg::new("root") | |||
| .long("root") | |||
| .help("Installation root") | |||
| .value_parser(value_parser!(PathBuf)) | |||
There was a problem hiding this comment.
I don't like this because it gives a false sense of what kind of data this is.
kt3k
pushed a commit
that referenced
this pull request
Nov 17, 2023
zifeo
pushed a commit
to metatypedev/deno
that referenced
this pull request
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21160