Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: remove knowledge of promise IDs from deno #21132

Merged
merged 1 commit into from
Nov 9, 2023
Merged

perf: remove knowledge of promise IDs from deno #21132

merged 1 commit into from
Nov 9, 2023

Conversation

mmastrac
Copy link
Contributor

@mmastrac mmastrac commented Nov 9, 2023 •
edited
Loading

We can move all promise ID knowledge to deno_core, allowing us to better experiment with promise implementation in deno_core.

{un,}refOpPromise(promise) is equivalent to {un,}refOp(promise[promiseIdSymbol])

@mmastrac mmastrac force-pushed the ref_unref_promise branch 2 times, most recently from d70e885 to ebbbb59 Compare November 9, 2023 19:19
aapoalas
aapoalas approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice <3

@mmastrac mmastrac merged commit 9010b8d into denoland:main Nov 9, 2023
13 checks passed
@mmastrac
Copy link
Contributor Author

/bench http[minimal]

@denobot
Copy link
Collaborator

denobot commented Nov 10, 2023 •
edited
Loading

http[minimal]

rps latency bytes relative
node 87,974 112.73 µs σ=33.85 748,466 kB -71.7%
bun 310,988 31.86 µs σ=22.16 1,533,203 kB best
deno 173,802 55.6 µs σ=13.87 1,425,781 kB -44.1%
deno-baseline 169,562 57.11 µs σ=13.81 1,386,718 kB -45.5%

start: Fri, 10 Nov 2023 01:14:11 GMT

id: bf50f1e1-1746-4dd8-9243-12d4e08064eb

server: b623de65-1a87-49cd-9dc9-6a139a8871c1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aapoalas aapoalas aapoalas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmastrac @denobot @aapoalas