chore(cli): Migrate some unit tests to "Promise.withResolvers()" #21128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mmastrac
reviewed
Nov 10, 2023
| @@ -172,19 +172,23 @@ Deno.test(async function multipleCrons() { | |||
|
|
|||
| let count0 = 0; | |||
| let count1 = 0; | |||
| const promise0 = deferred(); | |||
| const promise1 = deferred(); | |||
| const { promise: promise0, resolve: resolve0 } = Promise.withResolvers< | |||
There was a problem hiding this comment.
Nit/bikeshed: stylistically it might be better to do const promise0 = Promise.withResolvers(...) and then promise0.resolve and await promise0.promise.
kt3k
pushed a commit
that referenced
this pull request
Nov 17, 2023
) Migrate to use `Promise.withResolvers()` instead of `deferred` in some of the tests in `cli/tests/unit/`. Issue: #21041
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to use
Promise.withResolvers()instead ofdeferredin some of the tests incli/tests/unit/.Issue: #21041