Revert ""deno.disableUpgradeCheck" workspace setting"

This reverts commit 2c4d55a.

cli/lsp/config.rs

@@ -462,9 +462,6 @@ pub struct WorkspaceSettings {
  #[serde(default = "default_document_preload_limit")]
  pub document_preload_limit: usize,
 
- #[serde(default)]
- pub disable_upgrade_check: bool,
-
  #[serde(default)]
  pub suggest: DenoCompletionSettings,
 
@@ -507,7 +504,6 @@ impl Default for WorkspaceSettings {
  internal_debug: false,
  lint: true,
  document_preload_limit: default_document_preload_limit(),
- disable_upgrade_check: false,
  suggest: Default::default(),
  testing: Default::default(),
  tls_certificate: None,
@@ -886,10 +882,6 @@ impl Config {
  }
  }
 
- pub fn disabled_upgrade_check(&self) -> bool {
- self.settings.unscoped.disable_upgrade_check
- }
-
  /// Determine if any inlay hints are enabled. This allows short circuiting
  /// when there are no inlay hints enabled.
  pub fn enabled_inlay_hints_for_specifier(
@@ -1354,7 +1346,6 @@ mod tests {
  internal_debug: false,
  lint: true,
  document_preload_limit: 1_000,
- disable_upgrade_check: false,
  suggest: DenoCompletionSettings {
  imports: ImportCompletionSettings {
  auto_discover: true,

cli/lsp/language_server.rs

@@ -3114,10 +3114,8 @@ impl tower_lsp::LanguageServer for LanguageServer {
 
  async fn initialized(&self, _: InitializedParams) {
  let mut registrations = Vec::with_capacity(2);
- let disabled_upgrade_check;
  let client = {
  let mut ls = self.0.write().await;
- disabled_upgrade_check = ls.config.disabled_upgrade_check();
  if ls
  .config
  .client_capabilities
@@ -3190,23 +3188,21 @@ impl tower_lsp::LanguageServer for LanguageServer {
 
  lsp_log!("Server ready.");
 
- if !disabled_upgrade_check {
- let http_client = self.0.read().await.http_client.clone();
- match check_for_upgrades_for_lsp(http_client).await {
- Ok(version_info) => {
- client.send_did_upgrade_check_notification(
- lsp_custom::DidUpgradeCheckNotificationParams {
- upgrade_available: version_info.map(
- |(latest_version, is_canary)| lsp_custom::UpgradeAvailable {
- latest_version,
- is_canary,
- },
- ),
- },
- );
- }
- Err(err) => error!("Failed to check for upgrades: {err}"),
+ let http_client = self.0.read().await.http_client.clone();
+ match check_for_upgrades_for_lsp(http_client).await {
+ Ok(version_info) => {
+ client.send_did_upgrade_check_notification(
+ lsp_custom::DidUpgradeCheckNotificationParams {
+ upgrade_available: version_info.map(
+ |(latest_version, is_canary)| lsp_custom::UpgradeAvailable {
+ latest_version,
+ is_canary,
+ },
+ ),
+ },
+ );
  }
+ Err(err) => error!("Failed to check for upgrades: {err}"),
  }
  }
 

cli/lsp/repl.rs

@@ -300,7 +300,6 @@ pub fn get_repl_workspace_settings() -> WorkspaceSettings {
  internal_debug: false,
  lint: false,
  document_preload_limit: 0, // don't pre-load any modules as it's expensive and not useful for the repl
- disable_upgrade_check: false,
  tls_certificate: None,
  unsafely_ignore_certificate_errors: None,
  unstable: false,

cli/tests/integration/lsp_tests.rs

@@ -1589,7 +1589,6 @@ fn lsp_workspace_disable_enable_paths() {
  "enable": false,
  "disablePaths": ["./worker/node.ts"],
  "enablePaths": ["./worker"],
- "disableUpgradeCheck": true,
  } }),
  );
 
@@ -6410,8 +6409,7 @@ fn lsp_semantic_tokens_for_disabled_module() {
  builder.set_deno_enable(false);
  },
  json!({ "deno": {
- "enable": false,
- "disableUpgradeCheck": true,
+ "enable": false
  } }),
  );
  client.did_open(json!({

test_util/src/lsp.rs

@@ -683,7 +683,6 @@ impl LspClient {
  "config": null,
  "importMap": null,
  "lint": true,
- "disableUpgradeCheck": true,
  "suggest": {
  "autoImports": true,
  "completeFunctionCalls": false,