feat(ext/websocket): websockets over http2 #21040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
changed the title
bartlomieju
reviewed
Nov 1, 2023
tools/wpt/expectation.json
Outdated
Comment on lines
+172
to
+174
| // TODO(mmastrac): this is possibly just too difficult, but we'll never call it | ||
| unimplemented!() | ||
| } |
There was a problem hiding this comment.
Are we sure this won't be hit?
There was a problem hiding this comment.
Yep -- I explicitly disabled the writev flag on fastwebsockets for H2.
bartlomieju
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
WebSocketover http/2. This requires a conformant http/2 server supporting the extended connect protocol.Passes approximately 100 new WPT tests (mostly
?wpt_flags=h2versions of existing websockets APIs).This is implemented as a fallback when http/1.1 fails, so a server that supports both h1 and h2 WebSockets will still end up on the http/1.1 upgrade path.
The patch also cleas up the websockets handshake to split it up into http, https+http1 and https+http2, making it a little less intertwined.
This uncovered a likely bug in the WPT test server: web-platform-tests/wpt#42896