Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): multiple deno.json scopes #21029

Closed
wants to merge 21 commits into from

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Oct 31, 2023

TODO:

  • Remove remaining invocations of the ConfigTree::root_*() methods. This includes Documents resolver creation, setting and vendor dirs.
  • Tests.
  • Adjust specifier-enabled logic on the vscode_deno side. Will probably add a request for this to ask the server if a specifier is enabled instead of recreating the detection. Need to figure out how to integrate that.
  • Rebase.

@bartlomieju
Copy link
Member

@nayeemrmn something's gone wrong when merging with main, there's a ton of unrelated commits. Could you try rebasing it once again?

@nayeemrmn
Copy link
Collaborator Author

This project is complete as of #24345 landing

@nayeemrmn nayeemrmn closed this Jun 26, 2024
@nayeemrmn nayeemrmn deleted the lsp-deno-json-scopes branch June 26, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants