chore: use kqueue backend of notify on macOS #21028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
bartlomieju
reviewed
Oct 31, 2023
|
Hard to tell until all of the PRs land. This one needs review: #18072 |
bartlomieju
approved these changes
Oct 31, 2023
mmastrac
reviewed
Oct 31, 2023
cli/tests/unit/fs_events_test.ts
Outdated
| @@ -32,7 +32,7 @@ async function getTwoEvents( | |||
| const events = []; | |||
| for await (const event of iter) { | |||
| events.push(event); | |||
| if (events.length > 2) break; | |||
| if (events.length >= 2) break; | |||
There was a problem hiding this comment.
Nit: leave a comment here describing why it might be > 2 in some cases.
littledivy
added a commit
that referenced
this pull request
Nov 1, 2023
This reverts commit 646afdf.
littledivy
added a commit
that referenced
this pull request
Nov 1, 2023
Reverts #21028 Reason: https://github.com/notify-rs/notify/blob/main/notify/src/kqueue.rs#L79-L81 Need to wait for the watcher thread to spawn otherwise we hit flakes --------- Signed-off-by: Divy Srivastava <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20996
"macos_fsevent" feature of notify links us to CoreFoundation on macOS.