fix(ext/node): socket setTimeout #20930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarybethGasman
force-pushed
the
fix/socket-setTimeout
branch
from
3df8bfe
to
761973d
Compare
|
|
|
tanmeng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
MarybethGasman
force-pushed
the
fix/socket-setTimeout
branch
2 times, most recently
from
0552199
to
2303d04
Compare
MarybethGasman
force-pushed
the
fix/socket-setTimeout
branch
from
2303d04
to
e25be6d
Compare
bartlomieju
reviewed
Oct 18, 2023
|
Sure. |
MarybethGasman
force-pushed
the
fix/socket-setTimeout
branch
from
7c758c1
to
e25be6d
Compare
bartlomieju
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
I verified that this test fails on main. Nice fix, thank you @MarybethGasman!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fix #20923
I use the implementation in 02_timers.js.