refactor: add WatcherInterface helper struct #20927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
commented
Oct 18, 2023
cli/util/file_watcher.rs
Outdated
| @@ -109,26 +108,85 @@ fn create_print_after_restart_fn(clear_screen: bool) -> impl Fn() { | |||
| } | |||
| } | |||
|
|
|||
| // TODO(bartlomieju): this is a poor name; change it | |||
| /// And interface to interact with Deno's CLI file watcher. | |||
| pub struct WatcherInterface { | |||
There was a problem hiding this comment.
@dsherret any suggestions for the name of this struct?
There was a problem hiding this comment.
WatcherChannel maybe (or WatcherCommunicator). We should probably avoid names that end in Interface.
There was a problem hiding this comment.
Maybe like WatcherChannel. It's bidirectional communication between inside and outside the watched operation
This reverts commit 4ff0cc6.
nayeemrmn
reviewed
Oct 19, 2023
dsherret
approved these changes
Oct 19, 2023
cli/util/file_watcher.rs
Outdated
| @@ -109,26 +108,85 @@ fn create_print_after_restart_fn(clear_screen: bool) -> impl Fn() { | |||
| } | |||
| } | |||
|
|
|||
| // TODO(bartlomieju): this is a poor name; change it | |||
| /// And interface to interact with Deno's CLI file watcher. | |||
| pub struct WatcherInterface { | |||
There was a problem hiding this comment.
WatcherChannel maybe (or WatcherCommunicator). We should probably avoid names that end in Interface.
| tokio::sync::mpsc::unbounded_channel(); | ||
| let (restart_tx, mut restart_rx) = tokio::sync::mpsc::unbounded_channel(); | ||
| let (changed_paths_tx, changed_paths_rx) = tokio::sync::broadcast::channel(4); |
There was a problem hiding this comment.
It would be nice if we could bury all these channels into WatcherInterface (then rename WatcherInterface to WatcherChannel maybe).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for #20876