Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): resolve file.d specifiers in npm packages #20918

Merged
merged 2 commits into from
Oct 16, 2023
Merged

fix(node): resolve file.d specifiers in npm packages #20918

merged 2 commits into from
Oct 16, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Oct 16, 2023 •
edited
Loading

Makes type checking octokit work.

Closes #20854

@dsherret dsherret changed the title fix(node): resolve .d specifiers in npm packages fix(node): resolve file.d specifiers in npm packages Oct 16, 2023
bartlomieju
bartlomieju approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit cb70c4d into denoland:main Oct 16, 2023
13 checks passed
@dsherret dsherret deleted the fix_d_ext_types2 branch October 16, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@kt3k kt3k Awaiting requested review from kt3k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot import .d.ts in node modules
2 participants
@dsherret @bartlomieju